Skip to content

WIP for test#715

Open
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:test-5.0
Open

WIP for test#715
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:test-5.0

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented May 6, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated catalog image references from v4.22 to v5.0 for certified-operators, community-operators, and redhat-operators across configuration manifests.
    • Configuration otherwise unchanged (poll intervals and other settings remain the same); no public APIs or exported interfaces were modified.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eb0ec4e0-52cf-4f44-a9e2-44ad7db54dc8

📥 Commits

Reviewing files that changed from the base of the PR and between d6431c1 and 142a1b8.

📒 Files selected for processing (3)
  • openshift/catalogd/manifests-experimental.yaml
  • openshift/catalogd/manifests.yaml
  • openshift/helm/catalogd.yaml
✅ Files skipped from review due to trivial changes (1)
  • openshift/helm/catalogd.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • openshift/catalogd/manifests.yaml
  • openshift/catalogd/manifests-experimental.yaml

Walkthrough

Three configuration files update OpenShift catalog image references and a Helm catalog version from v4.22 to v5.0; no other fields or public API signatures were changed.

Changes

Catalog Version Upgrade to v5.0

Layer / File(s) Summary
Experimental Manifests
openshift/catalogd/manifests-experimental.yaml		 Three ClusterCatalog resources (openshift-certified-operators, openshift-community-operators, openshift-redhat-operators) update spec.source.image.ref from ...:v4.22 to ...:v5.0.
Standard Manifests
openshift/catalogd/manifests.yaml		 Same three ClusterCatalog resources update image ref from registry.redhat.io/...:v4.22 to ...:v5.0.
Helm Configuration
openshift/helm/catalogd.yaml		 openshift.catalogs[].version value changed from v4.22 to v5.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'WIP for test' is vague and generic, not descriptive of the actual changes being made. Replace the title with a descriptive summary of the main change, such as 'Update catalogd image references from v4.22 to v5.0' to clearly communicate the primary purpose of the changeset.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML manifest files (not test files). Custom check for Ginkgo test names only applies to test files (.go), which are unchanged. Check is not applicable.
Test Structure And Quality ✅ Passed PR contains manifest version updates only (v4.22→v5.0) and codebase adds. No Ginkgo tests present - repository uses standard Go testing with testify. Custom check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed New Ginkgo tests in olmv1.go are protected from MicroShift via exutil.SkipMicroshift(oc) in their parent Describe block's BeforeEach function.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests added. PR modifies only YAML configuration files (manifests and Helm values), not test code. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates catalog image version references (v4.22→v5.0). No new scheduling constraints introduced. Existing constraints predate this PR and are unmodified.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML config files, not Go code. OTE Binary Stdout Contract applies to Go binaries only. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. Changes are limited to YAML manifest and Helm values files updating version references. The IPv6/disconnected network compatibility check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dtfranz and grokspawn May 6, 2026 14:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@tmshort tmshort mentioned this pull request May 6, 2026
Open
@tmshort
TEMP for test
142a1b8 
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-ovn-single-node 142a1b8 link false /test e2e-aws-upgrade-ovn-single-node
ci/prow/verify-commits 142a1b8 link true /test verify-commits
ci/prow/e2e-aws-techpreview-olmv1-ext 142a1b8 link true /test e2e-aws-techpreview-olmv1-ext
ci/prow/openshift-e2e-aws 142a1b8 link true /test openshift-e2e-aws
ci/prow/default-catalog-consistency 142a1b8 link true /test default-catalog-consistency
ci/prow/e2e-aws-olmv1-ext 142a1b8 link true /test e2e-aws-olmv1-ext

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtfranz dtfranz Awaiting requested review from dtfranz

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tmshort